Modified Arch Linux PKGBUILD to remove unnecessary output #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #6 the call to
make clean-version get-versioncreates a lot of additional output apart from the version. The first line with the call toclean-version version/version.jsonmakes sure theversion/version.jsontarget is already built so it doesn't create additional output in themake get-versioncall. I'm sure this could be solved more elegantly in the Makefile but I was unsure about other build commands which might be dependent on that exact behavior so I just created this workaround in the PKGBUILD. This is my first time working with PKGBUILD and Makefiles so please correct me, if there is a more suitable way to solve this.