fix: store values after a missed hit (#236)

monicahq · Jan 16, 2022 · 8b8db66 · 8b8db66
1 parent e17029f
commit 8b8db66
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Http/Middleware/TrustProxies.php b/src/Http/Middleware/TrustProxies.php
@@ -17,8 +17,11 @@ class TrustProxies extends Middleware
      */
     protected function setTrustedProxyIpAddresses(Request $request)
     {
-        $cachedProxies = Cache::get(Config::get('laravelcloudflare.cache'), function () {
-            return LaravelCloudflare::getProxies();
+        $cacheKey = Config::get('laravelcloudflare.cache');
+        $cachedProxies = Cache::get($cacheKey, function () use ($cacheKey) {
+            return tap(LaravelCloudflare::getProxies(), function ($proxies) use ($cacheKey) {
+                Cache::forever($cacheKey, $proxies);
+            });
         });
 
         if (is_array($cachedProxies) && count($cachedProxies) > 0) {

diff --git a/tests/Unit/Http/Middleware/TrustProxiesTest.php b/tests/Unit/Http/Middleware/TrustProxiesTest.php
@@ -59,5 +59,6 @@ public function it_load_trustproxies()
         $proxies = $request->getTrustedProxies();
 
         $this->assertEquals(['expect'], $proxies);
+        $this->assertEquals(['expect'], $this->app['cache']->get('cloudflare.proxies'));
     }
 }