fix for the Issue #186 - #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2019 12:07
…utOfBounds exception is thrown while processing the empty cells for some files
Comment on lines
-52
to
+55
| if (str!=null && str.length()>0) { | ||
| if (cacheSize > 0 || (str!=null && str.length()>0)) { |
There was a problem hiding this comment.
Are you sure that empty (but not null) strings shouldn't be added to the shared string table?
Not adding it (when it is expected) could mess up all the subsequent indexes. Reading values in an Excel row could then receive the wrong values from the shared string table.
|
I have the same issue ! this PR is still alive ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when SST cache size is set, IndexOutOfBounds exception is thrown while processing the empty cells for some files.
The file subject to the bug have been added to test resources