Fixed Camera orientation #956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlymonkai
force-pushed
the
fix/MN-726/camera-orientation
branch
from
4539606 to
f3a8a35
Compare
packages/camera-web/test/Camera/hooks/useCameraPreview.test.tsx
Outdated
Show resolved
Hide resolved
on iOS device: window.matchMedia('(orientation: portrait)') can be
unreliable.
dlymonkai
force-pushed
the
fix/MN-726/camera-orientation
branch
from
f3a8a35 to
4751e5b
Compare
gabrieltmonkai
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed camera orientation and dimension handling to fix unreliable behavior on iOS devices by moving from window.matchMedia('(orientation: portrait)') to using direct video element properties.
Removed dimension tracking from useUserMedia hook, eliminating reliance on MediaStreamTrack.getSettings() and window.matchMedia() for orientation detection
Moved dimension calculation to useCameraPreview hook, which now derives dimensions from the video element's videoWidth and videoHeight properties via onloadedmetadata and onresize events
Overview
Jira Ticket Reference : MN-726
Checklist before requesting a review