Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Menu URL provider #68

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Jun 19, 2024

For now, I ignore the class from PHP Stan.
Later it could be nice to find a way to test it depending on the menu classes exists or not.

Demo

cd tests/Application; sf composer require monsieurbiz/sylius-menu-plugin

Then :

Enregistrement.de.l.ecran.2024-06-19.a.14.44.08.mov

@madamebiz madamebiz added the Status: needs review Status: needs review label Jun 19, 2024
@maximehuran maximehuran requested a review from welcoMattic June 19, 2024 12:50
phpstan.neon Show resolved Hide resolved
src/Menu/PageUrlProvider.php Show resolved Hide resolved
@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Status: needs review labels Jun 20, 2024
@welcoMattic welcoMattic removed their request for review June 20, 2024 07:57
@maximehuran maximehuran requested a review from delyriand June 20, 2024 09:15
@madamebiz madamebiz added Status: needs review Status: needs review and removed Status: needs update This Issue/PR needs update labels Jun 20, 2024
@maximehuran maximehuran merged commit 2802ac4 into monsieurbiz:master Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: needs review Status: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants