Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase EXI limit to 7500 (CPISU-1276) #15

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

tnn
Copy link
Contributor

@tnn tnn commented Dec 18, 2024

Description

What?

Increase the EXI payload limit for Get15118EVCertificate from 5600 to 7500 characters.

Increased the timeout when waiting for async completion of responses during tests from 1 sec to 5 sec, due to GHA build failures.

Why?

Allow a 4-chain certificate chain to be included and allows vehicles to signal support for multiple OEM / MO roots when requesting Contract Certificates.
Required by Hubject Plug&Charge: https://support.hubject.com/hc/en-us/articles/9174328536221-3-6-Requirements-for-CPMS

2.2 Deviation from OCPP Message Get15118EVCertificate (processual)

Context

As part of implementing support for Plug&Charge. This is categorized as an bug, but we have not yet run into this problem in production.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • add further detail on which functionality would break and how to migrate

@tnn tnn requested a review from a team as a code owner December 18, 2024 12:51
@tnn tnn requested review from a team and removed request for a team December 18, 2024 12:51
Copy link

github-actions bot commented Dec 18, 2024

Test Results

52 tests   52 ✅  3s ⏱️
13 suites   0 💤
13 files     0 ❌

Results for commit af053e8.

♻️ This comment has been updated with latest results.

@tnn tnn force-pushed the fix/PnC_exi_limits branch from 19dac04 to 0f5d948 Compare January 2, 2025 14:40
Copy link

github-actions bot commented Jan 2, 2025

Code Coverage

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@tnn tnn merged commit b8f0103 into main Jan 3, 2025
7 checks passed
@tnn tnn deleted the fix/PnC_exi_limits branch January 3, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants