errors: export Status2TerrCode #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR exports the errors.Status2TerrCode function. It is currently unexported, and also unused. I'd like to export this as it is useful for implementing custom error filters, for example, when using a Typhon client to talk to third-party APIs, it may be necessary to implement custom logic to deserialize errors returned into Terrors. As part of that, it is common to translate the response HTTP status codes into Terror error codes. In our codebase, I can see around 15 re-implementations of this mapping, so I think there is sufficient usage for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports the errors.Status2TerrCode function. It is currently unexported, and also unused.
I'd like to export this as it is useful for implementing custom error filters, for example, when using a Typhon client to talk to third-party APIs, it may be necessary to implement custom logic to deserialize the errors returned into Terrors. As part of that, it is common to translate the response HTTP status codes into Terror error codes.
In our codebase, I can see around 15 re-implementations of this mapping, so I think there is sufficient usage for this change.
Alternatively, I think there's an argument for this mapping to be in monzo/terrors, because a number of the usages I found actually have nothing to do with monzo/typhon, and it is just converting HTTP status codes returned by other clients into terrors to be returned.