-
Notifications
You must be signed in to change notification settings - Fork 476
Mobile app updated docs #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mobile app updated docs #1437
Conversation
Mobile 4842
[docs] app: Document new displayinusermenu option
[docs] Accessibility mobile app VPAT
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ping @junpataleta for the review (VPAT), please notice it also include additional updates |
|
||
</InvalidExample> | ||
|
||
If a constant needs to be used in a component template, it should be declared in the component without "static" because static properties cannot be used in templates. Please notice that the naming convention for non static properties is camelCase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Change "non static" to "non-static".
|
||
### Angular Signals | ||
|
||
All signals in class properties must be defined as readonly properties to avoid overriding the whole signal by mistake. This includes input signals, computed signals, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: "readonly" -> "read-only"
#### Moodle App | ||
|
||
The Moodle App was accredited to meet [WCAG 2.1 Level AA conformance](https://www.webkeyit.com/accessibility-services/accessibility-accreditations/moodle-mobile-app) on 9 May 2023. See [MOBILE-4182](https://moodle.atlassian.net/browse/MOBILE-4182) for more details. | ||
The Moodle App was accredited to meet WCAG 2.2 Level AA conformance on 7 April 2025. See [MOBILE-4595](https://moodle.atlassian.net/browse/MOBILE-4595) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to change "was accredited" to "has been accredited".
|
||
#### Moodle App | ||
|
||
An overview of Moodle App's conformance with the [WCAG 2.2](https://www.w3.org/TR/WCAG22/) guidelines can be found in our [accessibility conformance report](https://docs.moodle.org/en/Moodle_app_VPAT#WCAG_2.x_report). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realise that we'll have three links with an accessible name of accessibility conformance report
that point to different URLs, and this is an accessibility issue. Let's change
can be found in our [accessibility conformance report]
to
can be found in the [Moodle App accessibility conformance report]
I'll put up a separate pull request to fix LMS and Workplace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jleyva. I had a look and made some suggestions.
The non-accessibility changes also make sense to me. I just have some minor grammatical suggestions.
Cheers!
No description provided.