Change some links to their new docs counterparts

Not much to say, all the docs pages already migrated to the new docs, point to the new ones. Plus some change from http to https. Then, the plethora of fixture changes to accommodate to the new URLs.
moodlehq · Jun 11, 2024 · 5b79e06 · 5b79e06
1 parent 9f56880
commit 5b79e06
Show file tree

Hide file tree

Showing 12 changed files with 102 additions and 102 deletions.
diff --git a/remote_branch_checker/lib.php b/remote_branch_checker/lib.php
@@ -79,7 +79,7 @@ public function run($format, $patchset) {
             'title' => 'PHP lint problems',
             'abbr' => 'phplint',
             'description' => 'This section shows php lint problems in the code detected by php -l',
-            'url' => 'http://php.net/docs.php',
+            'url' => 'https://www.php.net/docs.php',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 5,
             'warningweight' => 1,
@@ -96,7 +96,7 @@ public function run($format, $patchset) {
             'title' => 'PHP coding style problems',
             'abbr' => 'phpcs',
             'description' => 'This section shows the coding style problems detected in the code by phpcs',
-            'url' => 'https://docs.moodle.org/dev/Coding_style',
+            'url' => 'https://moodledev.io/general/development/policies/codingstyle',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 5,
             'warningweight' => 1);
@@ -113,7 +113,7 @@ public function run($format, $patchset) {
                 'title' => 'Javascript coding style problems',
                 'abbr' => 'js',
                 'description' => 'This section shows the coding style problems detected in the code by eslint',
-                'url' => 'https://docs.moodle.org/dev/Javascript/Coding_style',
+                'url' => 'https://moodledev.io/docs/guides/javascript',
                 'codedir' => dirname($this->directory) . '/',
                 'errorweight' => 5,
                 'warningweight' => 1);
@@ -131,7 +131,7 @@ public function run($format, $patchset) {
                 'title' => 'CSS problems',
                 'abbr' => 'css',
                 'description' => 'This section shows CSS problems detected by stylelint',
-                'url' => 'https://docs.moodle.org/dev/CSS_coding_style',
+                'url' => 'https://moodledev.io/docs/apis/plugintypes/theme/styles',
                 'codedir' => dirname($this->directory) . '/',
                 'errorweight' => 5,
                 'warningweight' => 1);
@@ -148,7 +148,7 @@ public function run($format, $patchset) {
             'title' => 'PHPDocs style problems',
             'abbr' => 'phpdoc',
             'description' => 'This section shows the phpdocs problems detected in the code by local_moodlecheck',
-            'url' => 'https://docs.moodle.org/dev/Coding_style',
+            'url' => 'https://moodledev.io/general/development/policies/codingstyle#documentation-and-comments',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 3,
             'warningweight' => 1);
@@ -180,7 +180,7 @@ public function run($format, $patchset) {
             'title' => 'Update savepoints problems',
             'abbr' => 'savepoint',
             'description' => 'This section shows problems detected with the handling of upgrade savepoints',
-            'url' => 'https://docs.moodle.org/dev/Upgrade_API',
+            'url' => 'https://moodledev.io/docs/guides/upgrade',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 50,
             'warningweight' => 10);
@@ -196,7 +196,7 @@ public function run($format, $patchset) {
             'title' => 'Third party library modification problems',
             'abbr' => 'thirdparty',
             'description' => 'This section shows problems detected with the modification of third party libraries',
-            'url' => 'https://docs.moodle.org/dev/Peer_reviewing#Third_party_code',
+            'url' => 'https://moodledev.io/general/development/process/peer-review#third-party-code',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 5,
             'warningweight' => 1,
@@ -213,7 +213,7 @@ public function run($format, $patchset) {
             'title' => 'Missing changes in external functions or backup support for new detected tables or columns',
             'abbr' => 'externalbackup',
             'description' => 'This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas.',
-            'url' => 'https://docs.moodle.org/dev/Peer_reviewing#The_Moodle_mobile_app',
+            'url' => 'https://moodledev.io/general/development/process/peer-review#the-moodle-mobile-app',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 5,
             'warningweight' => 1,
@@ -230,7 +230,7 @@ public function run($format, $patchset) {
             'title' => 'grunt changes',
             'abbr' => 'grunt',
             'description' => 'This section shows files built by grunt and not commited',
-            'url' => 'https://docs.moodle.org/dev/Grunt',
+            'url' => 'https://moodledev.io/general/development/tools/nodejs',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 5,
             'warningweight' => 1,
@@ -265,7 +265,7 @@ public function run($format, $patchset) {
             'title' => 'Mustache template problems',
             'abbr' => 'mustache',
             'description' => 'This section shows problems detected in mustache templates',
-            'url' => 'https://docs.moodle.org/dev/Templates',
+            'url' => 'https://moodledev.io/docs/guides/templates',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 5,
             'warningweight' => 1,
@@ -282,7 +282,7 @@ public function run($format, $patchset) {
             'title' => 'Gherkin .feature problems',
             'abbr' => 'gherkin',
             'description' => 'This section shows problems detected in behat .feature files',
-            'url' => 'https://docs.moodle.org/dev/Writing_acceptance_tests',
+            'url' => 'https://moodledev.io/general/development/tools/behat/writing',
             'codedir' => dirname($this->directory) . '/',
             'errorweight' => 5,
             'warningweight' => 1,

diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_all_passing.xml b/tests/fixtures/remote_branch_checker/local_ci_fixture_all_passing.xml
@@ -20,55 +20,55 @@
     <description>This section shows the general problems detected when processing the code</description>
     <mess/>
   </check>
-  <check id="phplint" title="PHP lint problems" url="http://php.net/docs.php" numerrors="0" numwarnings="0" allowfiltering="0">
+  <check id="phplint" title="PHP lint problems" url="https://www.php.net/docs.php" numerrors="0" numwarnings="0" allowfiltering="0">
     <description>This section shows php lint problems in the code detected by php -l</description>
     <mess/>
   </check>
-  <check id="phpcs" title="PHP coding style problems" url="https://docs.moodle.org/dev/Coding_style" numerrors="0" numwarnings="0" allowfiltering="1">
+  <check id="phpcs" title="PHP coding style problems" url="https://moodledev.io/general/development/policies/codingstyle" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows the coding style problems detected in the code by phpcs</description>
     <mess/>
   </check>
-  <check id="js" title="Javascript coding style problems" url="https://docs.moodle.org/dev/Javascript/Coding_style" numerrors="0" numwarnings="0" allowfiltering="1">
+  <check id="js" title="Javascript coding style problems" url="https://moodledev.io/docs/guides/javascript" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows the coding style problems detected in the code by eslint</description>
     <mess/>
   </check>
-  <check id="css" title="CSS problems" url="https://docs.moodle.org/dev/CSS_coding_style" numerrors="0" numwarnings="0" allowfiltering="1">
+  <check id="css" title="CSS problems" url="https://moodledev.io/docs/apis/plugintypes/theme/styles" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows CSS problems detected by stylelint</description>
     <mess/>
   </check>
-  <check id="phpdoc" title="PHPDocs style problems" url="https://docs.moodle.org/dev/Coding_style" numerrors="0" numwarnings="0" allowfiltering="1">
+  <check id="phpdoc" title="PHPDocs style problems" url="https://moodledev.io/general/development/policies/codingstyle#documentation-and-comments" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows the phpdocs problems detected in the code by local_moodlecheck</description>
     <mess/>
   </check>
   <check id="commit" title="Commit messages problems" url="https://docs.moodle.org/dev/Commit_cheat_sheet#Provide_clear_commit_messages" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows the problems detected in the commit messages by the commits checker</description>
     <mess/>
   </check>
-  <check id="savepoint" title="Update savepoints problems" url="https://docs.moodle.org/dev/Upgrade_API" numerrors="0" numwarnings="0" allowfiltering="1">
+  <check id="savepoint" title="Update savepoints problems" url="https://moodledev.io/docs/guides/upgrade" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows problems detected with the handling of upgrade savepoints</description>
     <mess/>
   </check>
-  <check id="thirdparty" title="Third party library modification problems" url="https://docs.moodle.org/dev/Peer_reviewing#Third_party_code" numerrors="0" numwarnings="0" allowfiltering="0">
+  <check id="thirdparty" title="Third party library modification problems" url="https://moodledev.io/general/development/process/peer-review#third-party-code" numerrors="0" numwarnings="0" allowfiltering="0">
     <description>This section shows problems detected with the modification of third party libraries</description>
     <mess/>
   </check>
-  <check id="externalbackup" title="Missing changes in external functions or backup support for new detected tables or columns" url="https://docs.moodle.org/dev/Peer_reviewing#The_Moodle_mobile_app" numerrors="0" numwarnings="0" allowfiltering="0">
+  <check id="externalbackup" title="Missing changes in external functions or backup support for new detected tables or columns" url="https://moodledev.io/general/development/process/peer-review#the-moodle-mobile-app" numerrors="0" numwarnings="0" allowfiltering="0">
     <description>This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas.</description>
     <mess/>
   </check>
-  <check id="grunt" title="grunt changes" url="https://docs.moodle.org/dev/Grunt" numerrors="0" numwarnings="0" allowfiltering="0">
+  <check id="grunt" title="grunt changes" url="https://moodledev.io/general/development/tools/nodejs" numerrors="0" numwarnings="0" allowfiltering="0">
     <description>This section shows files built by grunt and not commited</description>
     <mess/>
   </check>
   <check id="shifter" title="shifter problems" url="https://docs.moodle.org/dev/YUI/Shifter" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows problems detected by shifter</description>
     <mess/>
   </check>
-  <check id="mustache" title="Mustache template problems" url="https://docs.moodle.org/dev/Templates" numerrors="0" numwarnings="0" allowfiltering="0">
+  <check id="mustache" title="Mustache template problems" url="https://moodledev.io/docs/guides/templates" numerrors="0" numwarnings="0" allowfiltering="0">
     <description>This section shows problems detected in mustache templates</description>
     <mess/>
   </check>
-  <check id="gherkin" title="Gherkin .feature problems" url="https://docs.moodle.org/dev/Writing_acceptance_tests" numerrors="0" numwarnings="0" allowfiltering="1">
+  <check id="gherkin" title="Gherkin .feature problems" url="https://moodledev.io/general/development/tools/behat/writing" numerrors="0" numwarnings="0" allowfiltering="1">
     <description>This section shows problems detected in behat .feature files</description>
     <mess/>
   </check>

diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_gherkin_lint.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_gherkin_lint.regex
@@ -3,7 +3,7 @@
 # and its smurf.xml results.
 
 <detail name="gherkin" status="error" numerrors="3" numwarnings="0"/>
-<check id="gherkin" title="Gherkin .feature problems" url="https://docs.moodle.org/dev/Writing_acceptance_tests" numerrors="3" numwarnings="0" allowfiltering="1">
+<check id="gherkin" title="Gherkin .feature problems" url="https://moodledev.io/general/development/tools/behat/writing" numerrors="3" numwarnings="0" allowfiltering="1">
 <message>Feature name is already used in: mod/glossary/tests/behat/categories.feature</message>
 <message>Multiple empty lines are not allowed</message>
 <message>Wrong indentation for "and", expected indentation level of 4, but got 6</message>
diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_grunt_build_failed.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_grunt_build_failed.regex
@@ -3,6 +3,6 @@
 # and its smurf.xml results.
 
 <detail name="grunt" status="error" numerrors="1" numwarnings="1"/>
-<check id="grunt" title="grunt changes" url="https://docs.moodle.org/dev/Grunt" numerrors="1" numwarnings="1" allowfiltering="0">
+<check id="grunt" title="grunt changes" url="https://moodledev.io/general/development/tools/nodejs" numerrors="1" numwarnings="1" allowfiltering="0">
 <message>Problems running grunt</message>
 <message>Task "stylelint:scss" failed. Use --force to continue.</message>
diff --git a/tests/fixtures/remote_branch_checker/local_ci_fixture_mustache_lint.regex b/tests/fixtures/remote_branch_checker/local_ci_fixture_mustache_lint.regex
@@ -3,7 +3,7 @@
 # and its smurf.xml results.
 
 <detail name="mustache" status="error" numerrors="1" numwarnings="4"/>
-<problem file="lib/templates/html_validation.mustache" linefrom="1" lineto="1" method="" class="" package="" api="" diffurl="https://git.in.moodle.com/integration/prechecker/blob/23657cddae5d8d2ef45965d3e6d6d17d63f639c8/lib/templates/html_validation.mustache#L1" ruleset="moodle" rule="" url="https://docs.moodle.org/dev/Templates" type="warning" weight="1">
+<problem file="lib/templates/html_validation.mustache" linefrom="1" lineto="1" method="" class="" package="" api="" diffurl="https://git.in.moodle.com/integration/prechecker/blob/23657cddae5d8d2ef45965d3e6d6d17d63f639c8/lib/templates/html_validation.mustache#L1" ruleset="moodle" rule="" url="https://moodledev.io/docs/guides/templates" type="warning" weight="1">
 <message>HTML Validation error, line 4: End tag for  &#x201C;body&#x201D; seen, but there were unclosed elements.
 <message>HTML Validation error, line 2: Unclosed element &#x201C;span&#x201D;.
 <message>Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error