Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDLSITE-7296 Apply in the queue managers towards using rank #273

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Jul 13, 2023

This changes the picking order of both the normal and the continuous queue managers from previous:

  • Integration priority.
  • Issue priority.
  • Number of votes.
  • Last update/comment.

To a new:

  • Integration priority.
  • Issue rank (calculated elsewhere).

Worth noting that, together with the move we are also disabling a few previous automatisms:

  • Moving "important" issues from the candidates to the current queue. Now we are only moving issues by the new agreed sorting method above.
  • Stop raising the integration priority to 1 for issues waiting in the queue for more than X (configurable) days.

Also, worth noting that we aren't changing at this stage the 2 jobs in charge of managing the Integration priority of issues:

And they continue applying for the same logic as previously to control such a priority, namely:

  • Set the integration priority to 1 if the issue (any of):
    • Has the mdlqa label.
    • Has a Must fix X.Y version.
    • Has the security flag.
    • Comes from CLR
    • Is blocking others (and is not blocked by others).
  • Set the integration priority to 0 if the issue (any of):
    • Has null integration priority.
    • Has been reopened.
    • Has integration priority = 1 and is blocked by others.

This changes the picking order of both the normal and the
continuous queue managers from previous:

- Integration priority.
- Issue priority.
- Number of votes.
- Last update/comment.

To a new:

- Integration priority.
- Issue rank (calculated elsewhere).

Worth noting that, together with the move we are also disabling a few
previous automatisms:

- Moving "important" issues from the candidates to the current queue.
  Now we are only moving issues by the new agreed sorting method above.
- Stop raising the integration priority to 1 for issues waiting in
  the queue for more than X (configurable) days.

Also, worth noting that we aren't changing at this stage the 2 jobs in
charge of managing the Integration priority of issues:

- set_integration_priority_to_zero.sh
- set_integration_priority_to_one.sh

And they continue applying for the same logic as previously to
control such a priority, namely:

- Set the integration priority to 1 if the issue (any of):
  - Has the mdlqa label.
  - Has a Must fix X.Y version.
  - Has the security flag.
  - Comes from CLR
  - Is blocking others (and is not blocked by others).
- Set the integration priority to 0 if the issue (any of):
  - Has null integration priority.
  - Has been reopened.
  - Has integration priority = 1 and is blocked by others.
@stronk7 stronk7 marked this pull request as ready for review July 14, 2023 09:29
Copy link
Contributor

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Eloy. Looks straightforward and is in line with what has been discussed.

@junpataleta junpataleta merged commit e0ba650 into moodlehq:master Jul 14, 2023
4 checks passed
@stronk7 stronk7 deleted the switch_to_ranking_pickers branch July 14, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants