Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable back (partially) the move from candidates to current #278

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Aug 29, 2023

On continuous we want these "important" issues to be automatically moved to current integration, irrespectively of the "threshold" moves:

  • The issue has a must-fix version. [OR]
  • The issue has the mdlqa label.

Of course, only issues in the candidates queue, not held and not blocked by others.

Note that we have removed some of the old "important" criteria, namely:

  • The issue priority is critical or higher.
  • The issue is flagged as security issue.
  • The issue belongs to some of these components:
    • Privacy
    • Automated functional tests (behat)
    • Unit tests

See MDLSITE-7296 for more info (comments around 29 August 2023).

Tested with MDL-70371, seems to be working ok (that issue was a must-fix).

On continuous we want these "important" issues to be
automatically moved to current integration, irrespectively
of the "threshold" moves:
- The issue has a must-fix version. [OR]
- The issue has the mdlqa label.

Of course, only issues in the candidates queue, not held and not blocked
by others.

Note that we have removed some of the old "important" criteria, namely:
- The issue priority is critical or higher.
- The issue is flagged as security issue.
- The issue belongs to some of these components:
  - Privacy
  - Automated functional tests (behat)
  - Unit tests

See [MDLSITE-7296](https://tracker.moodle.org/browse/MDLSITE-7296) for
more info (comments around 29 August 2023).
@andrewnicols andrewnicols merged commit 6d226df into moodlehq:master Aug 30, 2023
4 checks passed
@stronk7 stronk7 deleted the move_important_to_current branch August 30, 2023 07:21
@stronk7
Copy link
Member Author

stronk7 commented Aug 30, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants