Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA is deprecating Node 16 actions, let's bump them #285

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Nov 15, 2023

Special note about the Bats action, we are moving
to a new one because the actual is not maintained.

amdilabs/setup-bats@v1 ==> brokenpip3/setup-bats-libs@1.5.1

Let's see how it goes...

@stronk7 stronk7 force-pushed the avoid_node16_deprecation_message branch from ffb165f to 0339ecb Compare November 15, 2023 13:11
Special note about the Bats action, we are moving
to a new one because the actual is not maintained.

amdilabs/setup-bats@v1 ==> brokenpip3/setup-bats-libs@1.5.1

Let's see how it goes...
@stronk7 stronk7 force-pushed the avoid_node16_deprecation_message branch from 0339ecb to 8abcf23 Compare November 15, 2023 15:39
@stronk7
Copy link
Member Author

stronk7 commented Nov 15, 2023

For reference, needed a few adjustments to the brokenpip3/setup-bats-libs@1.5.2 GHA to make it work without any warning (problem with GHA caching and default locations in the action).

Link: brokenpip3/setup-bats-libs#18

@stronk7
Copy link
Member Author

stronk7 commented Nov 15, 2023

Self-merging, so I can continue moving some tests...

@stronk7 stronk7 merged commit 4c4b34e into moodlehq:master Nov 15, 2023
4 checks passed
@stronk7 stronk7 deleted the avoid_node16_deprecation_message branch November 15, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant