Fixes the generation of displayname when integrateto is set to main #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snake
force-pushed
the
fix-remotebranchcheck-displayname
branch
from
3d61d97 to
87d2b95
Compare
|
Out of curiosity… that implies that MDK is dependent of the job display name? |
This is currently broken, causing things like mdk precheck to fail.
snake
force-pushed
the
fix-remotebranchcheck-displayname
branch
from
87d2b95 to
babb4d0
Compare
|
Merged, thanks @snake ! Hope it fixes the MDK problems... I'll be reviewing the whole CiBoT script later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently setting an empty string when 'integrateto' is set to 'main', causing tools like mdk precheck to fail. E.g.
https://integration.moodle.org/view/prechecker/job/Precheck%20remote%20branch/148255/console
That job uses MDL-79114-master as the branch name, but 'integrateto' is set to 'main' (see the job params), which results in the job failure. Running a job manually works fine, as long as integrateto is set to master.