Prevent plugin runs to use the moodle.Commenting.TodoComment sniff #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That sniff covers the core coding style and verifies that all the TODOs (inline or phpdoc block), have a MDL issue associated. But that's not a requirements for plugins, hence disabling that Sniff for them. Fixes moodlehq#289
|
Slef-merging this, so we have local_ci (and CiBoT) ready for the changes coming in moodle-cs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That sniff covers the core coding style and verifies that all the TODOs (inline or phpdoc block), have a MDL issue associated.
But that's not a requirements for plugins, hence disabling that Sniff for them.
Fixes #289