Use the patch HEAD commit to name the branches #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, we were using the merge commit to name the branches to be pushed. That's useless information because on every merge the commit is different. Instead, we are going to start using the patch HEAD commit (available in FETCH_HEAD) to name the branches, because that's some information that can be useful if some day we want to start checking what has been already checked and other niceties. Note that we are forcing to use a short commit length of 16 (to have it homogeneus), no matter that given our moodle.git repo size we are still only needing 11 right now. So any future search will need to be aware of this detail.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 32.87% 26.00% -6.88%
==========================================
Files 71 71
Lines 3215 3215
==========================================
- Hits 1057 836 -221
- Misses 2158 2379 +221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Annotating here these commands (filter, sort), to avoid forgetting them: |
paulholden
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, we were using the merge commit to name the branches to be pushed. That's useless information because on every merge the commit is different.
Instead, we are going to start using the patch HEAD commit (available in FETCH_HEAD) to name the branches, because that's some information that can be useful if some day we want to start checking what has been already checked and other niceties.
Note that we are forcing to use a short commit length of 16 (to have it homogeneus), no matter that given our moodle.git repo size we are still only needing 11 right now. So any future search will need to be aware of this detail.