Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop autoloading lib/outputcomponents.php if the classes already exist #306

Merged

Conversation

andrewnicols
Copy link
Contributor

MDL-82183 moved all of the output classes to support autoloading and added exceptions to prevent manual inclusion of these files.

MDL-82183 moved all of the output classes to support autoloading and
added exceptions to prevent manual inclusion of these files.
Copy link
Contributor

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Andrew! Spot-on patch!

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.97%. Comparing base (ee6273f) to head (76b8513).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   32.84%   25.97%   -6.87%     
==========================================
  Files          71       71              
  Lines        3218     3218              
==========================================
- Hits         1057      836     -221     
- Misses       2161     2382     +221     
Flag Coverage Δ
check_upgrade_savepoints 0.46% <ø> (ø)
checkstyle_manipulations 0.00% <ø> (ø)
compare_databases 2.39% <ø> (ø)
continuous_manage_queues_validation 0.71% <ø> (ø)
define_excluded 1.11% <ø> (ø)
detect_conflicts 1.49% <ø> (ø)
diff_extract_changes 0.00% <ø> (ø)
git_sync_two_branches 2.05% <ø> (ø)
grunt_process 3.01% <ø> (ø)
illegal_whitespace 2.64% <ø> (ø)
list_valid_components 0.00% <ø> (ø)
mustache_lint 2.82% <ø> (ø)
mustache_lint_plugins 1.30% <ø> (ø)
php_lint 1.21% <ø> (ø)
prepare_npm_stuff 1.52% <ø> (ø)
remote_branch_checker ?
remote_branch_reporter 0.00% <ø> (ø)
setup 0.00% <ø> (ø)
thirdparty_check 1.46% <ø> (ø)
travis-branch-checker 0.00% <ø> (ø)
upgrade_external_backup 1.61% <ø> (ø)
verifications 0.00% <ø> (ø)
verify_commit_messages 2.64% <ø> (ø)
verify_phpunit_xml 1.24% <ø> (ø)
versions_check_set 5.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junpataleta junpataleta merged commit 378fb23 into moodlehq:main Jun 27, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants