Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore whitespace issues in upgrade notes yml #309

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

andrewnicols
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.94%. Comparing base (dc590a5) to head (52d531e).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (dc590a5) and HEAD (52d531e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (dc590a5) HEAD (52d531e)
remote_branch_checker 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   32.99%   25.94%   -7.05%     
==========================================
  Files          71       71              
  Lines        3222     3222              
==========================================
- Hits         1063      836     -227     
- Misses       2159     2386     +227     
Flag Coverage Δ
check_upgrade_savepoints 0.46% <ø> (ø)
checkstyle_manipulations 0.00% <ø> (ø)
compare_databases 2.38% <ø> (ø)
continuous_manage_queues_validation 0.71% <ø> (ø)
define_excluded 1.11% <ø> (ø)
detect_conflicts 1.48% <ø> (ø)
diff_extract_changes 0.00% <ø> (ø)
git_sync_two_branches 2.04% <ø> (ø)
grunt_process 3.01% <ø> (ø)
illegal_whitespace 2.63% <ø> (ø)
list_valid_components 0.00% <ø> (ø)
mustache_lint 2.82% <ø> (ø)
mustache_lint_plugins 1.30% <ø> (ø)
php_lint 1.21% <ø> (ø)
prepare_npm_stuff 1.52% <ø> (ø)
remote_branch_checker ?
remote_branch_reporter 0.00% <ø> (ø)
setup 0.00% <ø> (ø)
thirdparty_check 1.45% <ø> (ø)
travis-branch-checker 0.00% <ø> (ø)
upgrade_external_backup 1.61% <ø> (ø)
verifications 0.00% <ø> (ø)
verify_commit_messages 2.63% <ø> (ø)
verify_phpunit_xml 1.24% <ø> (ø)
versions_check_set 5.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewnicols!
Thanks a lot for working on this improvement. The patch looks good and it's great you covered with tests. Well done!

There are a couple of tests failing, but they are unrelated to the patch, so I'm going to merge this (and then, in a separate issue, we can try to fix them).

Thanks @stronk7 for your help!! :-*

@sarjona sarjona merged commit b8dff00 into moodlehq:main Oct 3, 2024
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants