Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post the CiBoT and ToBiC results in dedicated custom fields in the Tracker (part 2) #313

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

junpataleta
Copy link
Contributor

  • CiBoT results will be posted in the "Pre-check results" field.
  • ToBiC results from the bulk_prelaunch_jobs will be posted in the "Automated test results" field.
  • The positions of the job URL and the job description have been switched.

With the ToBiC results no longer being posted as a comment, the
`commentedByUser()` condition is no longer applicable.

The condition
```
issue NOT IN updatedBy('tobic', '-${schedulemins}')
```
would have been great, but it does not work as described in the JIRA
9.12 documentation
https://confluence.atlassian.com/jirasoftwareserver0912/advanced-searching-functions-reference-1346049674.html
As the ToBiC results are now being posted to the
"Automated test results" custom field which is visible to all users who
can view the issue, the `restrictedto` parameter is no longer relevant
and should be removed.
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.14%. Comparing base (724ce0a) to head (ad2c00a).

Files with missing lines Patch % Lines
...mations/bulk_prelaunch_jobs/bulk_prelaunch_jobs.sh 0.00% 2 Missing ⚠️
..._issues/criteria/awaiting_integration/postissue.sh 0.00% 1 Missing ⚠️
..._issues/criteria/awaiting_peer_review/postissue.sh 0.00% 1 Missing ⚠️
...eck_issues/criteria/developer_request/postissue.sh 0.00% 1 Missing ⚠️
...iteria/awaiting_component_lead_review/postissue.sh 0.00% 1 Missing ⚠️
...ch_jobs/criteria/awaiting_integration/postissue.sh 0.00% 1 Missing ⚠️
...aunch_jobs/criteria/list_of_mdls_sdev/postissue.sh 0.00% 1 Missing ⚠️
...relaunch_jobs/criteria/multi_database/postissue.sh 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   33.00%   33.14%   +0.14%     
==========================================
  Files          71       71              
  Lines        3221     3207      -14     
==========================================
  Hits         1063     1063              
+ Misses       2158     2144      -14     
Flag Coverage Δ
check_upgrade_savepoints 0.46% <0.00%> (+<0.01%) ⬆️
checkstyle_manipulations 0.00% <0.00%> (ø)
compare_databases 2.40% <0.00%> (+0.01%) ⬆️
continuous_manage_queues_validation 0.71% <0.00%> (+<0.01%) ⬆️
define_excluded 1.12% <0.00%> (+<0.01%) ⬆️
detect_conflicts 1.49% <0.00%> (+<0.01%) ⬆️
diff_extract_changes 0.00% <0.00%> (ø)
git_sync_two_branches 2.05% <0.00%> (+<0.01%) ⬆️
grunt_process 3.02% <0.00%> (+0.01%) ⬆️
illegal_whitespace 2.65% <0.00%> (+0.01%) ⬆️
list_valid_components 0.00% <0.00%> (ø)
mustache_lint 2.83% <0.00%> (+0.01%) ⬆️
mustache_lint_plugins 1.30% <0.00%> (+<0.01%) ⬆️
php_lint 1.21% <0.00%> (+<0.01%) ⬆️
prepare_npm_stuff 1.52% <0.00%> (+<0.01%) ⬆️
remote_branch_checker 17.46% <0.00%> (+0.07%) ⬆️
remote_branch_reporter 0.00% <0.00%> (ø)
setup 0.00% <0.00%> (ø)
thirdparty_check 1.46% <0.00%> (+<0.01%) ⬆️
travis-branch-checker 0.00% <0.00%> (ø)
upgrade_external_backup 1.62% <0.00%> (+<0.01%) ⬆️
verifications 0.00% <0.00%> (ø)
verify_commit_messages 2.65% <0.00%> (+0.01%) ⬆️
verify_phpunit_xml 1.24% <0.00%> (+<0.01%) ⬆️
versions_check_set 5.05% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuongNV13 HuongNV13 self-requested a review October 14, 2024 03:01
@HuongNV13
Copy link
Contributor

Thanks, Jun
The changes look right to me!

@HuongNV13 HuongNV13 merged commit a99342b into moodlehq:main Oct 14, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants