Accept any _testcase as valid #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 31.07% 33.12% +2.05%
==========================================
Files 71 71
Lines 3215 3215
==========================================
+ Hits 999 1065 +66
+ Misses 2216 2150 -66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
andrewnicols
force-pushed
the
acceptAnyTestcase
branch
7 times, most recently
from
834649d to
c0a72e4
Compare
Historically we had a blur between `_test` and `_testcase`, but in recent versions we have largely solved this. We now expect: - every test class name to be suffixed with `_test` - every test class to be final - every test class to extend a testcase with class name suffixed `_testcase` - every testcase class to be abstract Given these parameters, which have been in place for some time and are checked with phpcs, we can move away from a hardcoded list of accepted testcases, and move towards a regular expression based on the name. There are still some uses of the legacy names, but we can reduce them and support any _testcase class.
andrewnicols
force-pushed
the
acceptAnyTestcase
branch
2 times, most recently
from
d7ba15e to
03e3425
Compare
andrewnicols
requested review from
stronk7 and
junpataleta
and removed request for
stronk7
junpataleta
reviewed
Nov 19, 2024
| externallib_advanced_testcase | ||
| googledocs_content_testcase | ||
| grade_base_testcase | ||
| lti_advantage_testcase | ||
| manage_category_test_base | ||
| messagelib_test |
There was a problem hiding this comment.
It looks like we can remove the following, and the test will still pass:
messagelib_testmod_quiz\\\\attempt_walkthrough_from_csv_test
Is there a reason they were not removed here?
stronk7
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we had a blur between
_testand_testcase, but in recent versions we have largely solved this. We now expect:_test_testcaseGiven these parameters, which have been in place for some time and are checked with phpcs, we can move away from a hardcoded list of accepted testcases, and move towards a regular expression based on the name.