Fix nvm loading issue.

We should not rely on success exit status from nvm.sh loading. Fixes #309
moodlehq · Aug 29, 2024 · d204da6 · d204da6
1 parent 8d14f75
commit d204da6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -9,6 +9,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 The format of this change log follows the advice given at [Keep a CHANGELOG](http://keepachangelog.com).
 
 ## [Unreleased]
+### Changed
+- Fixed nvm loading issue caused by upstream regression.
 
 ## [3.4.13] - 2023-09-02
 ### Changed

diff --git a/src/Installer/VendorInstaller.php b/src/Installer/VendorInstaller.php
@@ -129,7 +129,7 @@ public function installNode()
         }
 
         $nvmDir  = getenv('NVM_DIR');
-        $cmd     = ". $nvmDir/nvm.sh && nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
+        $cmd     = ". $nvmDir/nvm.sh; nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
         $process = $this->execute->passThrough($cmd, $this->moodle->directory);
         if (!$process->isSuccessful()) {
             throw new \RuntimeException('Node.js installation failed.');