Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove phpdbg support #289

Open
stronk7 opened this issue Mar 15, 2024 · 0 comments
Open

Remove phpdbg support #289

stronk7 opened this issue Mar 15, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation task Some task to complete
Milestone
(v5) Towards mood...

Comments

@stronk7
Copy link
Member

stronk7 commented Mar 15, 2024

This is blocked by #213 that needs to be implemented first in v4 (deprecation).

But, for sure phpdbg doesn't work with PHPUnit 10 and up anymore, so we must drop support in v5 yes or yes.

Ciao :-)
@stronk7 stronk7 added task Some task to complete documentation Improvements or additions to documentation labels Mar 15, 2024
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Apr 6, 2024
@stronk7
Deprecate the phpdbg option for code coverage
a44ddef 
This includes both the current default (when neither pcov or
xdebug are available) and the explicit use of --coverage-phpdbg

Since PHP 8.0, phpdbg is causing all sort of problems and is
not recommended. So it's time to deprecate it in order to
proceed to remove it completely for moodle-plugin-ci 5.0.0.

Removal ref.: moodlehq#289

Fixes moodlehq#213
@stronk7 stronk7 mentioned this issue Apr 6, 2024
Merged
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Apr 6, 2024
@stronk7
Deprecate the phpdbg option for code coverage
d6aead3 
This includes both the current default (when neither pcov or
xdebug are available) and the explicit use of --coverage-phpdbg

Since PHP 8.0, phpdbg is causing all sort of problems and is
not recommended. So it's time to deprecate it in order to
proceed to remove it completely for moodle-plugin-ci 5.0.0.

Removal ref.: moodlehq#289

Fixes moodlehq#213
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Apr 6, 2024
@stronk7
Deprecate the phpdbg option for code coverage
cdfb095 
This includes both the current default (when neither pcov or
xdebug are available) and the explicit use of --coverage-phpdbg

Since PHP 8.0, phpdbg is causing all sort of problems and is
not recommended. So it's time to deprecate it in order to
proceed to remove it completely for moodle-plugin-ci 5.0.0.

Removal ref.: moodlehq#289

Fixes moodlehq#213
mchurchward pushed a commit to brickfield/moodle-plugin-ci that referenced this issue May 30, 2024
@stronk7 @mchurchward
Deprecate the phpdbg option for code coverage
fbe223f 
This includes both the current default (when neither pcov or
xdebug are available) and the explicit use of --coverage-phpdbg

Since PHP 8.0, phpdbg is causing all sort of problems and is
not recommended. So it's time to deprecate it in order to
proceed to remove it completely for moodle-plugin-ci 5.0.0.

Removal ref.: moodlehq/moodle-plugin-ci#289

Fixes #213
mchurchward pushed a commit to brickfield/moodle-plugin-ci that referenced this issue May 30, 2024
@stronk7 @mchurchward
Deprecate the phpdbg option for code coverage
29eaeb8 
This includes both the current default (when neither pcov or
xdebug are available) and the explicit use of --coverage-phpdbg

Since PHP 8.0, phpdbg is causing all sort of problems and is
not recommended. So it's time to deprecate it in order to
proceed to remove it completely for moodle-plugin-ci 5.0.0.

Removal ref.: moodlehq/moodle-plugin-ci#289

Fixes #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation task Some task to complete
Projects
None yet
Milestone
(v5) Towards moodle-plugin-ci v5
Development

No branches or pull requests
1 participant
@stronk7