Deprecate the phpdbg option for code coverage #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
=========================================
Coverage 88.22% 88.22%
- Complexity 732 734 +2
=========================================
Files 76 76
Lines 2267 2267
=========================================
Hits 2000 2000
Misses 267 267 ☔ View full report in Codecov by Sentry. |
stronk7
force-pushed
the
deprecate_phpdbg
branch
from
a44ddef
to
d6aead3
Compare
This includes both the current default (when neither pcov or xdebug are available) and the explicit use of --coverage-phpdbg Since PHP 8.0, phpdbg is causing all sort of problems and is not recommended. So it's time to deprecate it in order to proceed to remove it completely for moodle-plugin-ci 5.0.0. Removal ref.: moodlehq#289 Fixes moodlehq#213
stronk7
force-pushed
the
deprecate_phpdbg
branch
from
d6aead3
to
cdfb095
Compare
|
Just for testing purposes, this is how the deprecation warning notification is displayed whenever https://github.com/stronk7/moodle-plugin-ci/actions/runs/8582321848 |
kabalin
approved these changes
Apr 6, 2024
|
Ta, K! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes both the current default (when neither pcov or xdebug are available) and the explicit use of --coverage-phpdbg
Since PHP 8.0, phpdbg is causing all sort of problems and is not recommended. So it's time to deprecate it in order to proceed to remove it completely for moodle-plugin-ci 5.0.0.
Removal ref.: #289
Fixes #213