Skip to content

Conversation

abias
Copy link
Contributor

@abias abias commented Sep 15, 2025

I created this patch based on my findings in #365.
Please double-check the composer.lock before merging the PR as it is not impossible that I did something wrong.

Copy link
Member

@kabalin kabalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abias, the bump looks good, but it also needs fixing the fixture code to address changes.

@abias
Copy link
Contributor Author

abias commented Oct 9, 2025

Thanks @kabalin ,

I will try to fix the fixture code and will ping you as soon it's ready and you can approve the Github actions run again.

Cheers,
Alex

@abias
Copy link
Contributor Author

abias commented Oct 9, 2025

Hi @kabalin ,

I have aligned the fixtures and tests and successfully ran the Github actions pipeline in my fork (where I do not have to wait for your approval).

Please approve the latest run here and have a look if the changes match your expectations.

Cheers,
Alex

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.33%. Comparing base (7e8efb4) to head (6669726).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #366   +/-   ##
=========================================
  Coverage     88.33%   88.33%           
  Complexity      763      763           
=========================================
  Files            77       77           
  Lines          2348     2348           
=========================================
  Hits           2074     2074           
  Misses          274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abias
Copy link
Contributor Author

abias commented Oct 10, 2025

Great!
Tests are green here as well except the "Integration tests (PHAR) (8.4, main, true)" job which is out of scope for this PR.

@kabalin
Copy link
Member

kabalin commented Oct 10, 2025

@abias thanks! The issue with postgres at integration test I will fix at release prep commit (somehow was overlooked).

@kabalin kabalin merged commit 5d87b14 into moodlehq:main Oct 10, 2025
28 of 30 checks passed
@abias abias deleted the issue-365 branch October 10, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants