-
Notifications
You must be signed in to change notification settings - Fork 51
Bump dependency for moodle-cs #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abias, the bump looks good, but it also needs fixing the fixture code to address changes.
Thanks @kabalin , I will try to fix the fixture code and will ping you as soon it's ready and you can approve the Github actions run again. Cheers, |
Hi @kabalin , I have aligned the fixtures and tests and successfully ran the Github actions pipeline in my fork (where I do not have to wait for your approval). Please approve the latest run here and have a look if the changes match your expectations. Cheers, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=========================================
Coverage 88.33% 88.33%
Complexity 763 763
=========================================
Files 77 77
Lines 2348 2348
=========================================
Hits 2074 2074
Misses 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great! |
@abias thanks! The issue with postgres at integration test I will fix at release prep commit (somehow was overlooked). |
I created this patch based on my findings in #365.
Please double-check the composer.lock before merging the PR as it is not impossible that I did something wrong.