Use selenium-firefox docker image version 2.53.1 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
requested changes
Jul 2, 2020
Also remove PROFILE env var in .travis.yml to prevent assumption that changing its value to `firefox` will work (it won't if version remains 3). Also add moodle dir mount to selenium container to allow running file upload tests.
kabalin
force-pushed
the
selenium-firefox-downgrade
branch
from
5ec5e96
to
982d8c2
Compare
|
Thanks for review @andrewnicols , all comments have been addressed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match selenium-firefox version used in https://github.com/moodlehq/moodle-docker (using version 3 will cause failure).
This also adds moodle dir mount to selenium container to allow running file upload
tests (open-lms-open-source/moodle-plugin-ci#110 (comment)).
Also remove PROFILE env var in .travis.yml to prevent assumption that
changing its value to firefox will work (it won't if version remains 3).
The change is realsed to new feature since 2.0.5 release and already reflected in Changelog.