Skip to content

Fix client binary build after artifact-upload changes #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Apr 12, 2024

TODO: before merging make sure that the --no-cache is removed from the docker build

@RomarQ RomarQ requested review from a team as code owners April 12, 2024 08:43
@noandrea noandrea changed the title Disabled docker cache when building binary Fix client binary build after artifact-upload changes Apr 12, 2024
@noandrea noandrea added B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Apr 12, 2024
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Coverage Report

@@                        Coverage Diff                         @@
##           master   noandrea-tmp-force-delete-cache     +/-   ##
==================================================================
  Coverage   73.06%                            73.06%   0.00%     
  Files         228                               228             
  Lines       69944                             69944             
==================================================================
  Hits        51103                             51103             
  Misses      18841                             18841             
Files Changed Coverage

Coverage generated Fri Apr 12 20:57:59 UTC 2024

Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noandrea
Copy link
Contributor

on a second thought, it's better to leave the caching off for this particular build

@noandrea noandrea merged commit fadc387 into master Apr 15, 2024
32 checks passed
@noandrea noandrea deleted the noandrea-tmp-force-delete-cache branch April 15, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants