-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add regression tests for issues MOON-2822 MOON-2824 MOON-2702 #2781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better to instead design the smoke test to generically collect all of our "bad block regressions" as this has happened in the past with alpha net too. This smoke test should have a const record of chain, block, query/call and then verify against an expected result
Coverage Report@@ Coverage Diff @@
## master rq/smoking-tests +/- ##
====================================================
+ Coverage 80.92% 80.93% +0.01%
- Files 286 284 -2
- Lines 81813 81724 -89
====================================================
- Hits 66205 66136 -69
- Misses 15608 15588 -20
|
Also add a regression test for |
Added a case for this one, but it uses some available public endpoints for Moonbeam since the Other than that, extracted logic for bad cases so we can add more in the future or even for other networks. |
Cannot merge, but LGTM |
WASM runtime size check:Compared to target branchMoonbase runtime: 2168 KB (no changes) ✅ Moonbeam runtime: 2116 KB (no changes) ✅ Moonriver runtime: 2116 KB (no changes) ✅ Compared to latest release (runtime-3101)Moonbase runtime: 2168 KB (+2168 KB compared to latest release) Moonbeam runtime: 2116 KB (+140 KB compared to latest release) Moonriver runtime: 2116 KB (+2116 KB compared to latest release) |
LGTM |
What does it do?
Adds regression tests for recent eth_call errors