Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add regression tests for issues MOON-2822 MOON-2824 MOON-2702 #2781

Merged
merged 18 commits into from
Sep 17, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Apr 24, 2024

What does it do?

Adds regression tests for recent eth_call errors

@RomarQ RomarQ self-assigned this Apr 24, 2024
@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Apr 24, 2024
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to instead design the smoke test to generically collect all of our "bad block regressions" as this has happened in the past with alpha net too. This smoke test should have a const record of chain, block, query/call and then verify against an expected result

test/suites/smoke/test-old-regressions.ts Outdated Show resolved Hide resolved
test/suites/smoke/test-old-regressions.ts Outdated Show resolved Hide resolved
test/suites/smoke/test-old-regressions.ts Outdated Show resolved Hide resolved
test/suites/smoke/test-old-regressions.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Apr 24, 2024

Coverage Report

@@                 Coverage Diff                  @@
##           master   rq/smoking-tests      +/-   ##
====================================================
+ Coverage   80.92%             80.93%   +0.01%     
- Files         286                284       -2     
- Lines       81813              81724      -89     
====================================================
- Hits        66205              66136      -69     
- Misses      15608              15588      -20     
Files Changed Coverage
/node/service/src/lib.rs 61.64% (-0.23%) 🔽
/node/service/src/rpc.rs 84.90% (-0.10%) 🔽
/pallets/moonbeam-foreign-assets/src/lib.rs 68.18% (-0.88%) 🔽
/runtime/common/src/apis.rs 28.40% (+0.17%) 🔼
/runtime/moonbase/src/lib.rs 52.71% (-0.22%) 🔽
/runtime/moonbeam/src/lib.rs 46.92% (+0.07%) 🔼
/runtime/moonriver/src/lib.rs 47.14% (+0.07%) 🔼

Coverage generated Wed Sep 4 19:05:30 UTC 2024

@RomarQ
Copy link
Contributor Author

RomarQ commented Jul 2, 2024

Also add a regression test for MOON-2702.

@pLabarta pLabarta self-assigned this Aug 9, 2024
@pLabarta
Copy link
Contributor

Also add a regression test for MOON-2702.

Added a case for this one, but it uses some available public endpoints for Moonbeam since the context endpoint does not seem to provide tracing features. Would be great to have some reviews on this aspect and decide what to do with it.

Other than that, extracted logic for bad cases so we can add more in the future or even for other networks.

@pLabarta pLabarta requested review from noandrea, TarekkMA, a team, gonzamontiel and pLabarta and removed request for a team August 21, 2024 16:16
@pLabarta pLabarta changed the title test: add regression tests for issues MOON-2822 MOON-2824 test: add regression tests for issues MOON-2822 MOON-2824 MOON-2702 Aug 21, 2024
@RomarQ
Copy link
Contributor Author

RomarQ commented Aug 27, 2024

Cannot merge, but LGTM

Copy link
Contributor

github-actions bot commented Aug 28, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2168 KB (no changes) ✅

Moonbeam runtime: 2116 KB (no changes) ✅

Moonriver runtime: 2116 KB (no changes) ✅

Compared to latest release (runtime-3101)

Moonbase runtime: 2168 KB (+2168 KB compared to latest release) ⚠️

Moonbeam runtime: 2116 KB (+140 KB compared to latest release) ⚠️

Moonriver runtime: 2116 KB (+2116 KB compared to latest release) ⚠️

pLabarta
pLabarta previously approved these changes Aug 29, 2024
@RomarQ
Copy link
Contributor Author

RomarQ commented Sep 11, 2024

LGTM

gonzamontiel

This comment was marked as outdated.

@RomarQ RomarQ merged commit 15dda48 into master Sep 17, 2024
38 checks passed
@RomarQ RomarQ deleted the rq/smoking-tests branch September 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants