Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moonriver] Increase block gas limit #2808

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

noandrea
Copy link
Contributor

What does it do?

Increases the gas limit parameters from 15mln to 60mln gas per block

⚠️ Breaking Changes ⚠️

The gas consumed by a transaction may change significantly, this change also affects the gas price

What important points reviewers should know?

this change is related to #2735

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes labels May 21, 2024
@noandrea noandrea requested review from ahmadkaouk, a team, RomarQ and Agusrodri and removed request for a team May 21, 2024 09:43
Copy link
Contributor

Coverage Report

@@                      Coverage Diff                       @@
##           master   noandrea-update-gas-limits      +/-   ##
==============================================================
- Coverage   73.08%                       72.85%   -0.23%     
  Files         228                          228              
+ Lines       69829                        70048     +219     
==============================================================
  Hits        51031                        51031              
+ Misses      18798                        19017     +219     
Files Changed Coverage

Coverage generated Tue May 21 10:32:37 UTC 2024

Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noandrea noandrea merged commit c0f96ec into master May 23, 2024
33 checks passed
@noandrea noandrea deleted the noandrea-update-gas-limits branch May 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants