Tests: add inline snapshots for gas estimation & costs for Randomness #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
D2-notlive
WASM runtime size check:Compared to target branchMoonbase runtime: 2196 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2196 KB (+236 KB compared to latest release) Moonbeam runtime: 2140 KB (+216 KB compared to latest release) Moonriver runtime: 2132 KB (+208 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/randomness-snapshots +/- ##
=============================================================
Coverage 79.22% 79.22% 0.00%
Files 299 299
Lines 87253 87253
=============================================================
Hits 69118 69118
Misses 18135 18135
|
|
How ready is this? We should add the snapshots to more tests and commit the snap files. |
|
Now it should be good to go. I would merge this as it was required particularly for these tests and open an issue to track adding snapshots to (ideally) most of the tests that involve interacting with contracts. |
RomarQ
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add a new inline snapshot for estimates gas costs and their estimations for Lottery Demo tests.
What important points reviewers should know?
When running tests without the inline values in place, the tests will generate them and edit the test files.
Is there something left for follow-up PRs?
Vitest has support for storing snapshots in files next to the tests but Moonwall does not support it, it thinks they are other tests and thus fails.
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?