-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update local type generation scripts #2968
Conversation
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2228 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2228 KB (+232 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/ts-api-overhaul +/- ##
=========================================================
- Coverage 79.01% 78.96% -0.05%
Files 305 305
Lines 88446 88446
=========================================================
- Hits 69878 69834 -44
+ Misses 18568 18612 +44
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we are overriding Moonbase and Moonbeam types with Moonriver ones.
Took my some time to figure out what was going on. Seemed like the nodes did not shut down and because they used the same ports got the wrong metadata. Should be fixed now! |
@pLabarta |
Pnpm requires the workspace configs at the root, an alternative approach would be isolating the TS packages in a 'ts' folder or similar, but I don't quite like it either. I'm open to options if we want to maintain the root focused on Rust configs |
I see. I think it is fine if we keep it limited to those files |
What does it do?
Bump
@polkadot/api
versions and update scripts for updating the TypeScript Api from a local build. Also modified/test
to use the local package instead of the published one using pnpm workspaces.Usage:
There were some changes to tests to fix errors that appeared when upgrading deps.
What important points reviewers should know?
Is there something left for follow-up PRs?
Yes, following PRs should address:
Using new scripts for updating types in CI
Import types from
moonbeam-types-bundle
Review and update types in the bundle
Automate type generation for PRs
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?