Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP 🚧 : Fix zombie tests for State Migration PR #2970

Closed
wants to merge 69 commits into from

Conversation

pLabarta
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@pLabarta pLabarta added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Sep 23, 2024
Copy link
Contributor

github-actions bot commented Sep 23, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2188 KB (no changes) ✅

Moonbeam runtime: 2148 KB (no changes) ✅

Moonriver runtime: 2148 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2188 KB (+228 KB compared to latest release) ⚠️

Moonbeam runtime: 2148 KB (+224 KB compared to latest release) ⚠️

Moonriver runtime: 2148 KB (+224 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Coverage Report

@@                      Coverage Diff                       @@
##           master   pablo/fix-migration-zombie      +/-   ##
==============================================================
+ Coverage   79.31%                       79.39%   +0.08%     
  Files         298                          298              
+ Lines       87140                        87489     +349     
==============================================================
+ Hits        69114                        69454     +340     
+ Misses      18026                        18035       +9     
Files Changed Coverage
/pallets/moonbeam-lazy-migrations/src/lib.rs 83.54% (-8.77%) 🔽
/pallets/moonbeam-lazy-migrations/src/tests.rs 99.55% (-0.45%) 🔽
/runtime/common/src/migrations.rs 72.33% (+0.13%) 🔼

Coverage generated Mon Sep 23 19:19:01 UTC 2024

@pLabarta pLabarta closed this Sep 24, 2024
@pLabarta pLabarta deleted the pablo/fix-migration-zombie branch September 24, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants