Fix key iterator in lazy loading mode
#2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2196 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2196 KB (+236 KB compared to latest release) Moonbeam runtime: 2140 KB (+216 KB compared to latest release) Moonriver runtime: 2132 KB (+208 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/lazy-loading-improvements +/- ##
================================================================
- Coverage 79.31% 79.22% -0.09%
+ Files 298 299 +1
+ Lines 87140 87253 +113
================================================================
+ Hits 69114 69118 +4
+ Misses 18026 18135 +109
|
noandrea
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a disclaimer when starting the node in
lazy loadingmode.This PR fixes a issues related to the
lazy loadingnode feature:offchain-workerwhen in lazy loading mode (If needed in the future, we need to create a tokio runtime to be used by that thread)What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?