Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove suicided contracts lazy migration #3039

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Nov 11, 2024

What does it do?

Removes all logic related to the suicided contracts storage removal in pallet moonbeam-lazy-migrations.

The migration was already applied to the following runtimes:

  • Moonbeam
  • Moonbase (In progress)
  • Moonriver (In progress)

@RomarQ RomarQ added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Nov 11, 2024
@RomarQ RomarQ self-assigned this Nov 11, 2024
@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes and removed B0-silent Changes should not be mentioned in any release notes labels Nov 11, 2024
Copy link
Contributor

github-actions bot commented Nov 11, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2232 KB (no changes) ✅

Moonriver runtime: 2224 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2232 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2224 KB (+232 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                            Coverage Diff                             @@
##           master   rq/remove-suicided-contracts-migration      +/-   ##
==========================================================================
- Coverage   79.00%                                   78.99%   -0.01%     
- Files         305                                      303       -2     
- Lines       88458                                    88200     -258     
==========================================================================
- Hits        69878                                    69673     -205     
- Misses      18580                                    18527      -53     
Files Changed Coverage
/pallets/moonbeam-lazy-migrations/src/lib.rs 82.04% (-1.50%) 🔽
/pallets/moonbeam-lazy-migrations/src/tests.rs 99.27% (-0.28%) 🔽

Coverage generated Mon Nov 11 11:49:55 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant