Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for experimental block import strategy #3049

Merged
merged 10 commits into from
Nov 23, 2024
Merged

Add support for experimental block import strategy #3049

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a72adc
feat: don't override fork strategy in import_queue
RomarQ Nov 19, 2024
d51d864
update Cargo.lock
RomarQ Nov 19, 2024
77276cb
format code
RomarQ Nov 19, 2024
c77d49f
use ParachainBlockImport::new
RomarQ Nov 19, 2024
0a6f171
deprecate old fork strategy behaviour
RomarQ Nov 19, 2024
3ecef21
improve expression
RomarQ Nov 19, 2024
883cd5a
fix build
RomarQ Nov 19, 2024
9800728
change new behaviour to be an opt-in instead of the default
RomarQ Nov 19, 2024
ebc92b9
update moonkit dependency pin
RomarQ Nov 22, 2024
b9d5fae
enable experimental_block_import_strategy when using the dev service
RomarQ Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,7 @@ slices = "0.2.0"
strum = { version = "0.26.3", default-features = false, features = ["derive"] }
strum_macros = "0.24"
smallvec = "1.11.0"
p256 = { version = "0.13.2", default-features = false, features = [
"ecdsa"] }
p256 = { version = "0.13.2", default-features = false, features = ["ecdsa"] }
ansi_term = "0.12.1"

# Other (client)
Expand Down
5 changes: 5 additions & 0 deletions node/cli/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@ pub struct RunCmd {
#[clap(long)]
pub dev_service: bool,

/// Enable the new block import strategy
/// Deprecated in: https://github.com/Moonsong-Labs/moonkit/pull/43
#[clap(long)]
pub experimental_block_import_strategy: bool,

#[cfg(feature = "lazy-loading")]
#[clap(long)]
pub fork_chain_from_rpc: Option<String>,
Expand Down
Loading
Loading