Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more TS tests for pallet-xcm precompile #3107

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Agusrodri
Copy link
Contributor

What does it do?

Adds extra typescript tests for pallet-xcm precompile. The new tests mostly check the behavior at the moment of combining two assets, and also using the origin's chain native token to pay for fees.

@Agusrodri Agusrodri added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2276 KB (no changes) ✅

Moonbeam runtime: 2248 KB (no changes) ✅

Moonriver runtime: 2244 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2276 KB (+248 KB compared to latest release) ⚠️

Moonbeam runtime: 2248 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2244 KB (+232 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Coverage Report

@@                       Coverage Diff                       @@
##           master   agustin-xcm-precompile-tests     +/-   ##
===============================================================
  Coverage   74.49%                         74.49%   0.00%     
  Files         375                            375             
  Lines       95313                          95313             
===============================================================
  Hits        70998                          70998             
  Misses      24315                          24315             
Files Changed Coverage

Coverage generated Mon Dec 23 13:35:01 UTC 2024

@Agusrodri Agusrodri marked this pull request as ready for review December 16, 2024 20:16
Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the new native foreign assets

@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit and removed D2-notlive PR doesn't change runtime code (so can't be audited) B0-silent Changes should not be mentioned in any release notes labels Dec 20, 2024
RomarQ
RomarQ previously approved these changes Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants