Send priority fees to collators

[TarekkMA]

What does it do?

Expand on the work done in #2923 and #3043, and send the priority fees to the block author (collator).

What important points reviewers should know?

• This is how we handle fees in this change:
  • FeesTreasuryProportion is used to split the following
    • Substrate txs fees
    • Eth base fees
  • The eth priority fees / tips and substrate tips are sent fully to the block author.
• I've removed DealWithFees struct and replaced it with
  • DealWithSubstrateFeesAndTip
  • DealWithEthereumBaseFees
  • DealWithEthereumPriorityFees

Tests

Some tests that were checking fees have been updated. Previously, they used the block author (ALITH), who will now receive tips due to this change, causing inaccuracies in the calculations.

Reviewer Checklist:

• Base Eth Fees are split using FeesTreasuryProportion
• Substrate Base fees are split using FeesTreasuryProportion
• Priority fees and substrate tips are sent to the collator (Block author)
• Make sure all runtimes have the same implementation
• Changed test work the same way as before (I just changed the sender/revicver account)
• All the new functionality are tested correctly for all scenarios.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[github-actions]

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2268 KB (no changes) ✅

Moonbeam runtime: 2244 KB (no changes) ✅

Moonriver runtime: 2248 KB (no changes) ✅

Compared to latest release (runtime-3400)

Moonbase runtime: 2268 KB (+240 KB compared to latest release) ⚠️

Moonbeam runtime: 2244 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2248 KB (+236 KB compared to latest release) ⚠️

[github-actions]

Coverage Report

@@                    Coverage Diff                     @@
##           master   tarekkma/priority-fees      +/-   ##
==========================================================
+ Coverage   74.40%                   74.51%   +0.11%     
  Files         376                      376              
- Lines       95432                    95401      -31     
==========================================================
+ Hits        70998                    71088      +90     
- Misses      24434                    24313     -121     

Files Changed	Coverage
/runtime/moonbase/src/lib.rs	50.34% (-2.51%)	🔽
/runtime/moonbase/tests/common/mod.rs	97.10% (+0.03%)	🔼
/runtime/moonbase/tests/integration_test.rs	99.39% (+0.01%)	🔼
/runtime/moonbeam/src/lib.rs	44.41% (-2.70%)	🔽
/runtime/moonbeam/tests/common/mod.rs	94.80% (+0.06%)	🔼
/runtime/moonbeam/tests/integration_test.rs	99.39% (+0.01%)	🔼
/runtime/moonriver/src/lib.rs	44.63% (-2.71%)	🔽
/runtime/moonriver/tests/common/mod.rs	94.91% (+0.06%)	🔼
/runtime/moonriver/tests/integration_test.rs	99.37% (+0.01%)	🔼

Coverage generated Tue Jan 14 11:11:24 UTC 2025

[RomarQ]

The changes look good.

I think we should have common implementations of DealWithSubstrateFeesAndTip, DealWithEthereumBaseFees, DealWithEthereumPriorityFees in all runtimes.

[stiiifff]

LGTM 🚀