You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changed failure function call from fail!() to fail()
Category
Correctness Code Snippet
fail!("@lib.hello() != "Hello, world!"") Recommendation
Verify that fail() is the correct function name in MoonBit's testing framework. If this is a breaking change, ensure all test files are updated accordingly. Reasoning
The removal of the exclamation mark suggests either a syntax correction or an API change in the testing framework. Since this is a test assertion, it's critical to ensure the correct failure function is being used to properly report test failures.
Test error message contains redundant string literal
Category
Maintainability Code Snippet
fail("@lib.hello() != "Hello, world!"") Recommendation
Consider extracting the expected value into a constant:
letEXPECTED="Hello, world!"if@lib.hello() !=EXPECTED {
fail("Expected '${EXPECTED}' but got '${@lib.hello()}'")
}
Reasoning
The current error message duplicates the string literal. Using a constant and interpolated string would make the test more maintainable and provide better failure messages by showing both expected and actual values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.