Fix string indexing type warnings for UInt16 compatibility #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue.PriorityQueue Co-authored-by: openhands <openhands@all-hands.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed type compatibility warnings by updating string indexing operations to use UInt16 instead of Int. This addresses the breaking change where
string[i]now returns UInt16 instead of Int.Changes
Why These Changes Were Made
The MoonBit language introduced a breaking change where string indexing operations (
string[i]) now returnUInt16instead ofInt. This caused type warnings throughout the codebase. The minimal changes ensure:moon checkpasses without warningsImplementation Details
The fixes involve simple type conversions and annotations to align with the new string indexing behavior. These are minimal, targeted changes that address the core type compatibility issue without affecting the overall functionality of the pretty printer.