Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Spawn embeded Container chain node on data preservers assignment #666

Merged
merged 30 commits into from
Sep 6, 2024

Conversation

nanocryk
Copy link
Collaborator

Implements the logic to detect assignments and spawn emebed container chain service corresponding to assignment.

This is a proof of concept and will need further work in later PRs:

  • this is only implemented in simple container chain node for now. Code in command.rs should be refactored out in a separate crate to be used by frontier container, which should support customizing the RPC (to support frontier RPC).
  • only the spawning of the first assignment is tested. Additional work may be required to properly react to unassignment and re-assignment.

Blocked by moondance-labs/dancekit#32 which adds an OrchestratorChainInterface function.

@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 27, 2024
Copy link
Contributor

github-actions bot commented Aug 27, 2024

Coverage Report

(master)

@@                        Coverage Diff                        @@
##           master   jeremy-spawn-cc-on-assignment      +/-   ##
=================================================================
- Coverage   67.55%                          67.48%   -0.07%     
+ Files         262                             264       +2     
+ Lines       47490                           47895     +405     
=================================================================
+ Hits        32080                           32321     +241     
+ Misses      15410                           15574     +164     
Files Changed Coverage
/client/service-container-chain/src/spawner.rs 44.66% (-0.27%) 🔽
/container-chains/nodes/simple/src/cli.rs 72.73% (-5.84%) 🔽
/container-chains/nodes/simple/src/command.rs 24.01% (-2.21%) 🔽
/node/src/service.rs 22.90% (-0.72%) 🔽
/runtime/dancebox/src/lib.rs 88.60% (-0.14%) 🔽
/runtime/flashbox/src/lib.rs 45.53% (-0.97%) 🔽

Coverage generated Fri Sep 6 07:31:02 UTC 2024

node/src/cli.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@tmpolaczyk tmpolaczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Don't forget to merge back master again

@nanocryk nanocryk merged commit a896b54 into master Sep 6, 2024
38 checks passed
@nanocryk nanocryk deleted the jeremy-spawn-cc-on-assignment branch September 6, 2024 07:47
@tmpolaczyk tmpolaczyk restored the jeremy-spawn-cc-on-assignment branch September 10, 2024 13:33
@tmpolaczyk tmpolaczyk deleted the jeremy-spawn-cc-on-assignment branch September 10, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants