Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starlight collator rotation #668

Merged
merged 14 commits into from
Aug 30, 2024
Merged

Starlight collator rotation #668

merged 14 commits into from
Aug 30, 2024

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Aug 27, 2024 •
edited
Loading

Enables collator rotation in Starlight

@fgamundi fgamundi self-assigned this Aug 27, 2024
@fgamundi fgamundi added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Coverage Report

(master)

@@                        Coverage Diff                         @@
##           master   fg-starlight-collator-rotation      +/-   ##
==================================================================
+ Coverage   66.52%                           66.53%   +0.01%     
  Files         261                              261              
+ Lines       46168                            46230      +62     
==================================================================
+ Hits        30710                            30755      +45     
+ Misses      15458                            15475      +17
Files Changed Coverage
/pallets/collator-assignment/src/lib.rs 95.24% (+1.02%) 🔼
/primitives/traits/src/lib.rs 65.22% (-3.26%) 🔽
/solo-chains/runtime/starlight/src/lib.rs 27.13% (+1.95%) 🔼
/solo-chains/runtime/starlight/src/tests/common/mod.rs 96.17% (+0.03%) 🔼

Coverage generated Thu Aug 29 17:53:18 UTC 2024

@fgamundi fgamundi marked this pull request as ready for review August 28, 2024 08:50
@girazoki
Copy link
Collaborator

I am thinking we should have a rotation test in typescript but we dont :(. Maybe we can add one? I am not sure if the mock-proof injects any randomness, but maybe we can build it for that?

@fgamundi
Copy link
Contributor Author

@girazoki I've added a TS test. Let me know if I can improve it

tmpolaczyk
tmpolaczyk reviewed Aug 29, 2024
View reviewed changes
solo-chains/runtime/starlight/src/lib.rs Outdated Show resolved Hide resolved
solo-chains/runtime/starlight/src/lib.rs Outdated Show resolved Hide resolved
solo-chains/runtime/starlight/src/lib.rs Outdated Show resolved Hide resolved
@fgamundi fgamundi requested a review from girazoki August 29, 2024 17:12
girazoki
girazoki approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgamundi fgamundi merged commit 1ccbc3b into master Aug 30, 2024
37 checks passed
@fgamundi fgamundi deleted the fg-starlight-collator-rotation branch August 30, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

@tmpolaczyk tmpolaczyk tmpolaczyk approved these changes

Assignees

@fgamundi fgamundi

Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgamundi @girazoki @tmpolaczyk