Store collator fullness in collator_assignment pallet #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master tomasz-store-collator-fullness +/- ##
=================================================================
Coverage 67.20% 67.20% 0.00%
Files 262 262
+ Lines 46899 46906 +7
=================================================================
+ Hits 31515 31519 +4
+ Misses 15384 15387 +3
|
|
NO migration required because we only write data right? (we dont read it) |
girazoki
reviewed
Aug 30, 2024
girazoki
reviewed
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count number of collators assigned to any chain, divide that by
max_collatorsand store the resulting ratio in pallet storage. In the future, that value will be used together withtarget_container_chain_fullnessto adjust some params that are based on usage.