Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create function to calculate the relay prathread tank address in typescript #674

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Sep 6, 2024

We had hardcoded addresses before, now I added a function that creates the address on the fly by asking the relay through a runtime-api

@girazoki girazoki added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage Report

(master)

@@                                Coverage Diff                                 @@
##           master   girazoki-stop-using-hardcoded-parathread-tanks      +/-   ##
==================================================================================
- Coverage   67.55%                                           67.48%   -0.07%     
+ Files         262                                              264       +2     
+ Lines       47490                                            47895     +405     
==================================================================================
+ Hits        32080                                            32321     +241     
+ Misses      15410                                            15574     +164     
Files Changed Coverage
/client/service-container-chain/src/spawner.rs 44.66% (-0.27%) 🔽
/container-chains/nodes/simple/src/cli.rs 72.73% (-5.84%) 🔽
/container-chains/nodes/simple/src/command.rs 24.01% (-2.21%) 🔽
/node/src/service.rs 22.90% (-0.72%) 🔽
/runtime/dancebox/src/lib.rs 88.60% (-0.14%) 🔽
/runtime/flashbox/src/lib.rs 45.53% (-0.97%) 🔽

Coverage generated Fri Sep 6 15:07:50 UTC 2024

@girazoki girazoki merged commit 645538b into master Sep 6, 2024
38 checks passed
@girazoki girazoki deleted the girazoki-stop-using-hardcoded-parathread-tanks branch September 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants