Ethereum RPC Data Providers #680
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
reviewed
Sep 13, 2024
| @@ -59,10 +60,10 @@ pub struct SpawnedContainer { | |||
| /// Used to check the reference count, if it's 0 it means the database has been closed | |||
| pub backend: std::sync::Weak<ContainerChainBackend>, | |||
| /// Used to check the reference count, if it's 0 it means that the client has been closed. | |||
| pub client: std::sync::Weak<ContainerChainClient>, | |||
There was a problem hiding this comment.
This is unfortunate, this module only cares about the refcount so it shouldn't need this generic param everywhere... But I believe we would need unsafe code to remove it.
There was a problem hiding this comment.
Actually, would it work if you set the type to dyn Any? Try initializing it like this
client.clone() as Arc<dyn Any + Send + Sync>;
tmpolaczyk
reviewed
Sep 13, 2024
| @@ -1,5 +1,5 @@ | |||
| [toolchain] | |||
| channel = "1.78.0" | |||
| channel = "1.79.0" | |||
There was a problem hiding this comment.
This alone should be a separate PR, let's use the same version as polkadot-sdk has in the stable2407 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the spawning logic generic over the RuntimeApi, which allows to inject a
GenerateRpcBuilderthat can call runtime apis only present in specific runtimes (different in simple and frontier templates).