Eth Beacon receiver in dancelight #717
Merged
+2,028
−373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
B7-runtimenoteworthy
girazoki
commented
Oct 9, 2024
solo-chains/runtime/dancelight/src/bridge_to_ethereum_config.rs
Outdated
Show resolved
Hide resolved
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 836 KB (no changes) ✅ dancelight runtime: 1980 KB (no changes) ✅ container chain template simple runtime: 1096 KB (no changes) ✅ container chain template frontier runtime: 1392 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master girazoki-eth-receiver- +/- ##
==========================================================
+ Coverage 64.78% 64.93% +0.15%
+ Files 297 299 +2
+ Lines 51963 52255 +292
==========================================================
+ Hits 33661 33927 +266
+ Misses 18302 18328 +26
|
0xvgg
reviewed
Oct 11, 2024
tmpolaczyk
reviewed
Oct 14, 2024
tmpolaczyk
reviewed
Oct 14, 2024
solo-chains/runtime/dancelight/src/bridge_to_ethereum_config.rs
Outdated
Show resolved
Hide resolved
Agusrodri
reviewed
Oct 14, 2024
Agusrodri
approved these changes
Oct 14, 2024
tmpolaczyk
reviewed
Oct 17, 2024
tmpolaczyk
reviewed
Oct 18, 2024
ParthDesai
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Seems alright. Apart from the minor issue in test @tmpolaczyk reported.
tmpolaczyk
reviewed
Oct 21, 2024
tmpolaczyk
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the eth beacon receiver pallet from snowbridge. I also did set it up to Holesky in dancelight, as we will be connected to it.
I am mostly re-using the tests jsons generated by snowbridge in this case as I dont think it is worth generating new ones. These should also make sure our tests break if something in the pallet changes.
The main tests I am adding are for: