Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEEFY Testing #724

Merged
merged 23 commits into from
Oct 24, 2024
Merged

BEEFY Testing #724

merged 23 commits into from
Oct 24, 2024

Conversation

Agusrodri
Copy link
Collaborator

What does it do?

This PR adds overall testing around BEEFY protocol.

More specifically, some tests were added to cover the following general scenarios:

  • Digests inserted by BEEFY protocol (authorities and MMR root changes)
  • Double voting proofs
  • Future voting proofs
  • BEEFY genesis block

Note for reviewers

It was needed to push this commit to Moondance's polkadot-sdk fork, given that the previous weight hint for report_future_block_voting extrinsic was wrong. This was making the related TS test to fail (as the default weight for report_fork_voting is Weight::MAX).

We will not need to cherry-pick that commit in the next dependency upgrade, as the changes are already included in paritytech/polkadot-sdk#5188 for stable-2409. I didn't cherry-pick the full changes as I don't want to cause extra unnecessary conflicts before the next dependency upgrade.

@Agusrodri Agusrodri added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Oct 19, 2024
Copy link
Contributor

github-actions bot commented Oct 19, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1416 KB (no changes) ✅

flashbox runtime: 832 KB (no changes) ✅

dancelight runtime: 1980 KB (+1980 KB) ⚠️

container chain template simple runtime: 1096 KB (-4212 KB) ✅

container chain template frontier runtime: 1392 KB (-5132 KB) ✅

Copy link
Contributor

github-actions bot commented Oct 19, 2024

Coverage Report

(master)

@@                  Coverage Diff                   @@
##           master   agustin-test-beefy      +/-   ##
======================================================
+ Coverage   64.98%               65.25%   +0.27%     
+ Files         299                  300       +1     
+ Lines       52269                52639     +370     
======================================================
+ Hits        33964                34348     +384     
- Misses      18305                18291      -14     
Files Changed Coverage
/pallets/data-preservers/runtime-api/src/lib.rs 81.25% (+6.25%)
/pallets/stream-payment/runtime-api/src/lib.rs 95.83% (+8.33%)
/pallets/xcm-core-buyer/src/lib.rs 91.33% (+0.27%)
/runtime/dancebox/src/lib.rs 87.77% (+0.30%)
/solo-chains/runtime/dancelight/src/lib.rs 68.28% (+0.79%)
/solo-chains/runtime/dancelight/src/tests/common/mod.rs 96.91% (+0.49%)

Coverage generated Wed Oct 23 15:13:48 UTC 2024

@Agusrodri Agusrodri merged commit 404e67f into master Oct 24, 2024
41 checks passed
@Agusrodri Agusrodri deleted the agustin-test-beefy branch October 24, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants