-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slash + rewards e2e test version 1 #838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
added
not-breaking
Does not need to be mentioned in breaking changes
D2-notlive
PR doesn't change runtime/client code
B0-silent
Changes should not be mentioned in any release notes
labels
Jan 31, 2025
WASM runtime size check:Compared to target branchdancebox runtime: 1420 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2168 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
girazoki
reviewed
Jan 31, 2025
girazoki
approved these changes
Jan 31, 2025
0xvgg
approved these changes
Jan 31, 2025
Coverage Report@@ Coverage Diff @@
## master add-slashes-and-rewards-e2e +/- ##
==============================================================
Coverage 66.01% 66.01% 0.00%
Files 335 335
Lines 58789 58789
==============================================================
Hits 38809 38809
Misses 19980 19980
|
tmpolaczyk
reviewed
Jan 31, 2025
test/suites/zombie_tanssi_relay_eth_bridge/test_zombie_tanssi_relay_eth_bridge.ts
Show resolved
Hide resolved
tmpolaczyk
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B0-silent
Changes should not be mentioned in any release notes
D2-notlive
PR doesn't change runtime/client code
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements slash + rewards e2e tests version 1.
The version 1 only checks if the message is indicated to be successfully processed by gateway. But, it does not verify if it is processed by trying to claim the reward and actually checking if slash is applied. This will be implemented by version 2.
Other changes:
max_dispatch_gas
forReportRewards
andReportSlashes
to 1 million from 60k gas.