Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash + rewards e2e test version 1 #838

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

ParthDesai
Copy link
Contributor

Description

This PR implements slash + rewards e2e tests version 1.

The version 1 only checks if the message is indicated to be successfully processed by gateway. But, it does not verify if it is processed by trying to claim the reward and actually checking if slash is applied. This will be implemented by version 2.

Other changes:

  • We increased max_dispatch_gas for ReportRewards and ReportSlashes to 1 million from 60k gas.
  • We modified the test to check operator block production to check if operator is part of session validators.
  • We now start secondary governance channel relayer for token registration.

@ParthDesai ParthDesai added not-breaking Does not need to be mentioned in breaking changes D2-notlive PR doesn't change runtime/client code B0-silent Changes should not be mentioned in any release notes labels Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1420 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2168 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Coverage Report

(master)

@@                      Coverage Diff                       @@
##           master   add-slashes-and-rewards-e2e     +/-   ##
==============================================================
  Coverage   66.01%                        66.01%   0.00%     
  Files         335                           335             
  Lines       58789                         58789             
==============================================================
  Hits        38809                         38809             
  Misses      19980                         19980             
Files Changed Coverage

Coverage generated Fri Jan 31 14:43:40 UTC 2025

@ParthDesai ParthDesai merged commit bf6339c into master Jan 31, 2025
42 checks passed
@ParthDesai ParthDesai deleted the add-slashes-and-rewards-e2e branch January 31, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants