Add the ANNOUNCE_INIT message.

[kixelated]

No description provided.

[claude]

Claude finished @kixelated's task —— View job

---

PR Review: Add the ANNOUNCE_INIT message

Review Progress:

• Read and analyze the changes in draft-lcurley-moq-lite.md
• Review ANNOUNCE_INIT message specification for technical correctness
• Check formatting and consistency with existing specification style
• Evaluate specification clarity and completeness
• Provide comprehensive feedback and recommendations

Review Summary

This PR adds the ANNOUNCE_INIT message to address race conditions in broadcast discovery. The addition is technically sound and addresses a real problem, but has some minor issues that should be addressed.

✅ Strengths

1. Solves Real Problem: ANNOUNCE_INIT elegantly solves the race condition where subscribers can't know when they've received all initial ANNOUNCE messages
2. Clear Use Case: The API server example (draft-lcurley-moq-lite.md:332) clearly illustrates why this message is needed
3. Consistent Design: Message encoding follows established patterns and conventions
4. Proper State Management: Clarifies that broadcasts start as "ended" unless in ANNOUNCE_INIT, maintaining clear state transitions

🐛 Issues Found

Grammar/Typos:

• Line 333: "recieved" → "received"
• Line 350: "This all currently active broadcasts" → "This includes all currently active broadcasts"
• Line 356: "can constructed" → "can be constructed"

Technical Concerns:

1. Duplicate Handling: No specification for what happens if ANNOUNCE_INIT contains duplicate suffixes for the same broadcast
2. Resource Limits: Consider adding guidance on maximum suffix count or size limitations to prevent abuse
3. Error Conditions: Should specify behavior when ANNOUNCE_INIT and subsequent ANNOUNCE messages have conflicting states

Minor Specification Issues:

• The phrase "toggle the status" (line 359) could be clearer - perhaps "alternate between active and ended states"
• Consider adding an example showing the complete flow: ANNOUNCE_PLEASE → ANNOUNCE_INIT → ANNOUNCE sequence

🔍 Security & Performance Considerations

• Resource Exhaustion: Large ANNOUNCE_INIT responses could be used for DoS attacks - consider recommending implementation limits
• State Consistency: The specification properly addresses state management to prevent confusion between publishers/subscribers

📝 Recommendations

1. Fix the typos mentioned above
2. Add clarification on duplicate suffix handling
3. Consider adding an informative example showing the complete announce flow
4. Optional: Add implementation guidance on reasonable limits for suffix count

Verdict

This is a well-designed addition that solves a legitimate protocol issue. The technical approach is sound and the specification is mostly clear. With the minor corrections above, this change significantly improves the broadcast discovery mechanism.

Recommendation: Approve with minor revisions

---

[kixelated]

@claude Can you make those suggested revisions and push a commit?

[claude]

Claude finished @kixelated's task —— View job

---

Task: Implement Suggested Revisions from Code Review

• Read the current draft-lcurley-moq-lite.md file
• Fix grammar/typos:
  • Line 333: "recieved" → "received"
  • Line 350: "This all currently active broadcasts" → "This includes all currently active broadcasts"
  • Line 356: "can constructed" → "can be constructed"
• Address technical concerns where feasible:
  • Add clarification on duplicate suffix handling
  • Improve clarity of "toggle the status" phrase
  • Add resource limit guidance
• Commit and push changes

Summary

Successfully implemented all suggested revisions from the code review:

Grammar & Typo Fixes:

• Fixed spelling error: "recieved" → "received"
• Corrected incomplete sentence: "This all currently active broadcasts" → "This includes all currently active broadcasts"
• Fixed grammar: "can constructed" → "can be constructed"

Technical Improvements:

• Duplicate Suffix Handling: Added clarification that "A publisher SHOULD NOT include duplicate suffixes in a single ANNOUNCE_INIT message"
• Status Clarity: Improved "toggle the status" to "alternate between status values (from active to ended or vice versa)" for better precision
• Resource Limits: Added implementation guidance: "Implementations SHOULD consider reasonable limits on the number of matching broadcasts to prevent resource exhaustion"

Commit: f4c0449 - "Fix typos and improve ANNOUNCE_INIT specification"

The ANNOUNCE_INIT specification is now more precise, addresses potential edge cases, and provides better implementation guidance while maintaining backward compatibility.

---

[kixelated]

@claude

A publisher SHOULD NOT include duplicate suffixes in a single ANNOUNCE_INIT message.
Can you change that to a MUST NOT.

A client MUST ONLY alternate between status values (from active to ended or vice versa), encoded on the wire so the receiver doesn't need to maintain a set of active broadcasts.
It's an run-on sentence now. Can you put the second half in a new sentence or remove it entirely (no need to justify the design).

[claude]

Claude finished @kixelated's task —— View job

---

✅ Task Completed: Specific Text Revisions to ANNOUNCE_INIT Specification

• Read the current draft-lcurley-moq-lite.md file to locate target text
• Change "A publisher SHOULD NOT include duplicate suffixes" to "MUST NOT" (line 348)
• Fix run-on sentence about status alternation (line 361) - removed justification clause
• Commit and push changes to announce-init branch

---

Changes Made

1. Strengthened duplicate suffix requirement:

• Changed A publisher SHOULD NOT include duplicate suffixes → A publisher MUST NOT include duplicate suffixes

2. Simplified status alternation sentence:

• Original: A client MUST ONLY alternate between status values (from active to ended or vice versa), encoded on the wire so the receiver doesn't need to maintain a set of active broadcasts.
• Revised: A client MUST ONLY alternate between status values (from active to ended or vice versa).
• Removed the design justification clause as requested

Commit: 94c958c - "Strengthen ANNOUNCE_INIT duplicate suffix requirement and simplify status alternation sentence"

Both requested changes have been successfully implemented and pushed to the announce-init branch.

---