Skip to content

require_equals #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 2 commits into from
Feb 12, 2026
+9 −1
Merged

require_equals #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1717ed8
require_equals
kixelated Feb 12, 2026
e9cce33
Fix the tests.
kixelated Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion rs/moq-native/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ pub struct ClientTls {
env = "MOQ_CLIENT_TLS_DISABLE_VERIFY",
default_missing_value = "true",
num_args = 0..=1,
require_equals = true,
value_parser = clap::value_parser!(bool),
)]
pub disable_verify: Option<bool>,
Expand Down Expand Up @@ -352,10 +353,16 @@ mod tests {

#[test]
fn test_cli_disable_verify_explicit_false() {
let config = ClientConfig::parse_from(["test", "--tls-disable-verify", "false"]);
let config = ClientConfig::parse_from(["test", "--tls-disable-verify=false"]);
assert_eq!(config.tls.disable_verify, Some(false));
}

#[test]
fn test_cli_disable_verify_explicit_true() {
let config = ClientConfig::parse_from(["test", "--tls-disable-verify=true"]);
assert_eq!(config.tls.disable_verify, Some(true));
}

#[test]
fn test_cli_no_disable_verify() {
let config = ClientConfig::parse_from(["test"]);
Expand Down
1 change: 1 addition & 0 deletions rs/moq-native/src/iroh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ pub struct IrohEndpointConfig {
env = "MOQ_IROH_ENABLED",
default_missing_value = "true",
num_args = 0..=1,
require_equals = true,
value_parser = clap::value_parser!(bool),
)]
pub enabled: Option<bool>,
Expand Down
Loading