Fix HTTP/3 frame and capsule buffering in quiche #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Remove loop in Capsule::decode() - now decodes single capsule instead of skipping GREASE - Add explicit Grease variant to Capsule enum - Fix GREASE detection per RFC 9297 Section 5.4 (0x29 * N + 0x17) - Change Capsule::read() to return Option<Self> (returns None on clean EOF) - Update web-transport-quinn to handle new API This is foundational for properly handling HTTP/3 frames that may contain multiple capsules or GREASE values. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Changes: - Add buffering for leftover bytes after CONNECT handshake (capsule data can arrive with HEADERS frame) - Refactor run_closed() to properly read HTTP/3 DATA frames and decode multiple capsules per frame - Handle GREASE capsules explicitly - More robust frame parsing with cursor-based approach Previously, the code assumed Capsule::read() would handle the HTTP/3 framing, but it only handles capsule protocol. This fix properly extracts DATA frames first, then decodes capsules from the payload. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
run_closed()to properly read HTTP/3 DATA frames and decode multiple capsules per frameDetails
Previously, the code assumed
Capsule::read()would handle the HTTP/3 framing, but it only handles the capsule protocol layer. This fix properly:Dependencies
🤖 Generated with Claude Code