Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommunicationEventContent Services #152

Merged
merged 3 commits into from
May 9, 2020

Conversation

hellozhangwei
Copy link
Contributor

No description provided.

Wei Zhang and others added 3 commits October 30, 2018 11:44
@danieltaylor-nz danieltaylor-nz merged commit 85673cd into moqui:master May 9, 2020
@danieltaylor-nz
Copy link
Member

I checked this out and ran it locally without issue. Would you consider adding some Communication Event Content to the demo data here?

https://github.com/moqui/HiveMind/blob/master/data/HiveMindDemoData.xml

@danieltaylor-nz
Copy link
Member

I merged this, but unfortunately, I failed to request this change to be made first. So I implemented it myself in the following PR:
#154

@hellozhangwei
Copy link
Contributor Author

I checked this out and ran it locally without issue. Would you consider adding some Communication Event Content to the demo data here?

https://github.com/moqui/HiveMind/blob/master/data/HiveMindDemoData.xml

Yes, but I think it's better we have the uploading event communication content implemented for Add/Edit/Reply Comment on TaskSummary screen

@danieltaylor-nz
Copy link
Member

Yes, I saw that too. There was no easy way for me to test your PR as there was no demo data with content, and no easy way to add content.

@hellozhangwei
Copy link
Contributor Author

Please check PR moqui/HiveMind#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants