Open
Conversation
…undocumented types
credit to @stackotter for writing the original text in the Discord server
kaascevich
force-pushed
the
parameter-documentation
branch
from
bf7aca1 to
2634179
Compare
Contributor
Author
|
I'll probably wait to finish this PR until after the layout-performance branch is merged. |
Collaborator
Collaborator
|
Nvm you’ve already done that! |
…ith `Environment` type
stackotter
requested changes
Feb 15, 2026
Collaborator
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
I'm still working my way through these changes; I'm just submitting what I've got so far so I don't lose it.
stackotter
requested changes
Feb 16, 2026
Collaborator
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
I'm again still working through this, and I'm again just submitting what I've got so far so that I don't lose my progress. I've viewed 100/137 changed files.
Sources/SwiftCrossUI/Views/Modifiers/Layout/FrameModifier.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCrossUI/Views/Modifiers/Layout/FrameModifier.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCrossUI/Views/Modifiers/Layout/BackgroundModifier.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftCrossUI/Views/Modifiers/Handlers/OnOpenURLModifier.swift
Outdated
Show resolved
Hide resolved
stackotter
requested changes
Feb 16, 2026
Collaborator
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Great work with this PR! I'm sure that it was a lot of work, but it'll benefit almost everyone using the project.
Sources/SwiftCrossUI/SwiftCrossUI.docc/Implementation details.md
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, I've focused on adding documentation for parameters and return types, and documenting completely undocumented types. I'll improve on these (as well as the existing docs) as I become more familiar with SCUI's internals.